fix bug with incorrect shimmering size after requestLayout called#57
Open
VitalyNikonorov wants to merge 2 commits intoteam-supercharge:masterfrom
Open
fix bug with incorrect shimmering size after requestLayout called#57VitalyNikonorov wants to merge 2 commits intoteam-supercharge:masterfrom
VitalyNikonorov wants to merge 2 commits intoteam-supercharge:masterfrom
Conversation
Contributor
|
Hi @VitalyNikonorov, thanks for the pull request. I will have a look at it at the end of the week! |
Contributor
|
@VitalyNikonorov I checked the pull request. So yes, there is this bug that if you change the text for example after measure and layout phase and start the animation. However, if the animation is ongoing and I change the text, the animation will not be proper after applying your fix. |
veghtomi
suggested changes
Aug 11, 2018
Contributor
veghtomi
left a comment
There was a problem hiding this comment.
Check the conversation.
Author
|
@veghtomi I've made some changes. Now animation works with correct animating interval, but it does not take into account the correct position of shimmer mask (interpolator and size changes adjustment is required) |
Contributor
|
@VitalyNikonorov thanks for the fix, I will check it soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is incorrect shimmer animation after child view has been changed.
E.g.
If length of newText and text in
childViewis differ, than shimmer animation will be not correct