Skip to content

Conversation

@Sky-FE
Copy link
Contributor

@Sky-FE Sky-FE commented Nov 12, 2025

No description provided.

@Sky-FE Sky-FE requested a review from Copilot November 12, 2025 07:32
@Sky-FE Sky-FE added the preview This issue is already ready for preview label Nov 12, 2025
Copilot finished reviewing on behalf of Sky-FE November 12, 2025 07:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the grid view pre-filling feature to support multiple rows instead of just a single row. The implementation changes the data structure from a single field value map to an array of row objects, enabling users to add, edit, copy, paste, and delete multiple pre-filling rows before committing them to the database.

  • Refactored pre-filling state from single record to multiple records array
  • Added UI button to add additional pre-filling rows dynamically
  • Updated scroll bar visibility props to separate X and Y axis control

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/sdk/src/components/grid/InfiniteScroller.tsx Split scrollBarVisible into separate X/Y axis visibility controls
packages/sdk/src/components/grid/Grid.tsx Updated Grid interface to support independent X/Y scrollbar visibility
packages/sdk/src/components/grid-enhancements/hooks/use-grid-prefilling-row.ts Refactored from single record state to array of records, updated cell operations to work with multiple rows
packages/sdk/src/components/grid-enhancements/hooks/use-grid-popup-position.tsx Fixed maxHeight to properly use the provided parameter
packages/common-i18n/src/locales/*/table.json Added paste permission error message across all locales
apps/nextjs-app/src/features/app/blocks/view/grid/components/PrefillingRowContainer.tsx Added button and keyboard handler for adding new pre-filling rows
apps/nextjs-app/src/features/app/blocks/view/grid/GridViewBaseInner.tsx Integrated multiple pre-filling rows support, removed legacy ConfirmNewRecords dialog, updated copy/paste/delete operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2124.sealoshzh.site

@github-actions
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2124.sealoshzh.site

1 similar comment
@github-actions
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2124.sealoshzh.site

@github-actions
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2124.sealoshzh.site

@github-actions
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2124.sealoshzh.site

@github-actions
Copy link

Deployment Status: ✅ Success
🔗 Preview URL: https://pr-2124.sealoshzh.site

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 19360317245

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 74.309%

Files with Coverage Reduction New Missed Lines %
apps/nestjs-backend/src/features/base-sql-executor/base-sql-executor.service.ts 9 70.18%
Totals Coverage Status
Change from base Build 19357190916: -0.01%
Covered Lines: 54580
Relevant Lines: 73450

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview This issue is already ready for preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants