-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: pre-filling records in grid view #2124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the grid view pre-filling feature to support multiple rows instead of just a single row. The implementation changes the data structure from a single field value map to an array of row objects, enabling users to add, edit, copy, paste, and delete multiple pre-filling rows before committing them to the database.
- Refactored pre-filling state from single record to multiple records array
- Added UI button to add additional pre-filling rows dynamically
- Updated scroll bar visibility props to separate X and Y axis control
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/sdk/src/components/grid/InfiniteScroller.tsx | Split scrollBarVisible into separate X/Y axis visibility controls |
| packages/sdk/src/components/grid/Grid.tsx | Updated Grid interface to support independent X/Y scrollbar visibility |
| packages/sdk/src/components/grid-enhancements/hooks/use-grid-prefilling-row.ts | Refactored from single record state to array of records, updated cell operations to work with multiple rows |
| packages/sdk/src/components/grid-enhancements/hooks/use-grid-popup-position.tsx | Fixed maxHeight to properly use the provided parameter |
| packages/common-i18n/src/locales/*/table.json | Added paste permission error message across all locales |
| apps/nextjs-app/src/features/app/blocks/view/grid/components/PrefillingRowContainer.tsx | Added button and keyboard handler for adding new pre-filling rows |
| apps/nextjs-app/src/features/app/blocks/view/grid/GridViewBaseInner.tsx | Integrated multiple pre-filling rows support, removed legacy ConfirmNewRecords dialog, updated copy/paste/delete operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/nextjs-app/src/features/app/blocks/view/grid/components/PrefillingRowContainer.tsx
Show resolved
Hide resolved
|
Deployment Status: ✅ Success |
|
Deployment Status: ✅ Success |
1 similar comment
|
Deployment Status: ✅ Success |
|
Deployment Status: ✅ Success |
|
Deployment Status: ✅ Success |
|
Deployment Status: ✅ Success |
Pull Request Test Coverage Report for Build 19360317245Details
💛 - Coveralls |
No description provided.