-
Notifications
You must be signed in to change notification settings - Fork 514
Test export * as x from and import * as x; export { x } binding equivalence
#4606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...e-code/instn-iee-err-ambiguous_FIXTURE.js → ...ndings/error-export-from-named_FIXTURE.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| // Copyright (C) 2016 the V8 project authors. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| export * from './instn-iee-err-ambiguous-1_FIXTURE.js'; | ||
| export * from './instn-iee-err-ambiguous-2_FIXTURE.js'; | ||
| export * from './error-export-from-named-1_FIXTURE.js'; | ||
| export * from './error-export-from-named-2_FIXTURE.js'; |
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...dule-code/instn-star-ambiguous_FIXTURE.js → ...rt-bindings/error-import-named_FIXTURE.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| // Copyright (C) 2016 the V8 project authors. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| export * from './instn-star-ambiguous-1_FIXTURE.js'; | ||
| export * from './instn-star-ambiguous-2_FIXTURE.js'; | ||
| export * from './error-import-named-1_FIXTURE.js'; | ||
| export * from './error-import-named-2_FIXTURE.js'; |
80 changes: 80 additions & 0 deletions
80
test/language/module-code/ambiguous-export-bindings/import-and-export-propagates-binding.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| // Copyright (C) 2025 Igalia, S.L. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
| /*--- | ||
| description: A binding re-exported with `export { foo } from` and `import { foo } from; export { foo }` does not cause ambiguity. | ||
| esid: sec-source-text-module-record-initialize-environment | ||
| info: | | ||
| [...] | ||
| 7. For each ImportEntry Record in of module.[[ImportEntries]], do | ||
| a. Let importedModule be GetImportedModule(module, in.[[ModuleRequest]]). | ||
| b. If in.[[ImportName]] is namespace-object, then | ||
| i. Let namespace be GetModuleNamespace(importedModule). | ||
| ii. Perform ! env.CreateImmutableBinding(in.[[LocalName]], true). | ||
| iii. Perform ! env.InitializeBinding(in.[[LocalName]], namespace). | ||
| c. Else, | ||
| i. Let resolution be importedModule.ResolveExport(in.[[ImportName]]). | ||
| ii. If resolution is either null or ambiguous, throw a SyntaxError exception. | ||
|
|
||
| Table 59 (Informative): Export Forms Mappings to ExportEntry Records | ||
|
|
||
| Export Statement Form [[ExportName]] [[ModuleRequest]] [[ImportName]] [[LocalName]] | ||
| export {x}; "x" null null "x" | ||
| export {x} from "mod"; "x" "mod" "x" null | ||
|
|
||
| 16.2.1.7.1 ParseModule ( sourceText, realm, hostDefined ) | ||
| [...] | ||
| 10. For each ExportEntry Record ee of exportEntries, do | ||
| 1. If ee.[[ModuleRequest]] is null, then | ||
| i. If importedBoundNames does not contain ee.[[LocalName]], then | ||
| 1. Append ee to localExportEntries. | ||
| ii. Else, | ||
| 1. Let ie be the element of importEntries whose [[LocalName]] is ee.[[LocalName]]. | ||
| 2. If ie.[[ImportName]] is namespace-object, then | ||
| a. NOTE: This is a re-export of an imported module namespace object. | ||
| b. Append the ExportEntry Record { [[ModuleRequest]]: ie.[[ModuleRequest]], [[ImportName]]: ~all~, [[LocalName]]: *null*, [[ExportName]]: ee.[[ExportName]] } to indirectExportEntries. | ||
| 3. Else, | ||
| a. NOTE: This is a re-export of a single name. | ||
| b. Append the ExportEntry Record { [[ModuleRequest]]: ie.[[ModuleRequest]], | ||
| [[ImportName]]: ie.[[ImportName]], [[LocalName]]: null, [[ExportName]]: | ||
| ee.[[ExportName]] } to indirectExportEntries. | ||
| 2. Else if ee.[[ImportName]] is all-but-default, then | ||
| [...] | ||
| 3. Else, | ||
| a. Append ee to indirectExportEntries. | ||
|
|
||
| 15.2.1.16.3 ResolveExport | ||
|
|
||
| [...] | ||
| 6. For each ExportEntry Record e of module.[[IndirectExportEntries]], do | ||
| a. If e.[[ExportName]] is exportName, then | ||
| i. Assert: e.[[ModuleRequest]] is not null. | ||
| ii. Let importedModule be GetImportedModule(module, e.[[ModuleRequest]]). | ||
| iii. If e.[[ImportName]] is all, then | ||
| 1. Assert: module does not provide the direct binding for this export. | ||
| 2. Return ResolvedBinding Record { [[Module]]: importedModule, [[BindingName]]: namespace }. | ||
| [...] | ||
| 9. Let starResolution be null. | ||
| 10. For each ExportEntry Record e in module.[[StarExportEntries]], do | ||
| a. Let importedModule be GetImportedModule(module, | ||
| e.[[ModuleRequest]]). | ||
| b. Let resolution be ? importedModule.ResolveExport(exportName, | ||
| resolveSet, exportStarSet). | ||
| c. If resolution is ~ambiguous~, return ~ambiguous~. | ||
| d. If resolution is not null, then | ||
| i. If starResolution is null, let starResolution be resolution. | ||
| ii. Else, | ||
| 1. Assert: there is more than one * import that includes the | ||
| requested name. | ||
| 2. If _resolution_.[[Module]] and _starResolution_.[[Module]] are | ||
| not the same Module Record, return ~ambiguous~. | ||
| 3. If _resolution_.[[BindingName]] is not _starResolution_.[[BindingName]], | ||
| return ~ambiguous~. | ||
| flags: [module] | ||
| ---*/ | ||
|
|
||
| export * from "./import-and-export-propagates-binding_export-from_FIXTURE.js"; | ||
| export * from "./import-and-export-propagates-binding_import-and-export_FIXTURE.js"; | ||
|
|
||
| import { foo } from './import-and-export-propagates-binding.js'; | ||
|
|
||
| assert.sameValue(foo, 2); |
4 changes: 4 additions & 0 deletions
4
...age/module-code/ambiguous-export-bindings/import-and-export-propagates-binding_FIXTURE.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| // Copyright (C) 2025 Igalia, S.L. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| export const foo = 2; |
4 changes: 4 additions & 0 deletions
4
...ode/ambiguous-export-bindings/import-and-export-propagates-binding_export-from_FIXTURE.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| // Copyright (C) 2025 Igalia, S.L. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| export { foo } from "./import-and-export-propagates-binding_FIXTURE.js"; |
5 changes: 5 additions & 0 deletions
5
...biguous-export-bindings/import-and-export-propagates-binding_import-and-export_FIXTURE.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| // Copyright (C) 2025 Igalia, S.L. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| import { foo } from "./import-and-export-propagates-binding_FIXTURE.js"; | ||
| export { foo }; |
2 changes: 2 additions & 0 deletions
2
test/language/module-code/ambiguous-export-bindings/namespace-empty-module_FIXTURE.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| // Copyright (C) 2025 Igalia, S.L. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. |
4 changes: 4 additions & 0 deletions
4
...language/module-code/ambiguous-export-bindings/namespace-export-star-as-from-1_FIXTURE.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| // Copyright (C) 2025 Igalia, S.L. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| export * as foo from "./namespace-empty-module_FIXTURE.js"; |
4 changes: 4 additions & 0 deletions
4
...language/module-code/ambiguous-export-bindings/namespace-export-star-as-from-2_FIXTURE.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| // Copyright (C) 2025 Igalia, S.L. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| export * as foo from "./namespace-empty-module_FIXTURE.js"; |
5 changes: 5 additions & 0 deletions
5
...ge/module-code/ambiguous-export-bindings/namespace-import-star-as-and-export-1_FIXTURE.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| // Copyright (C) 2025 Igalia, S.L. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| import * as foo from "./namespace-empty-module_FIXTURE.js"; | ||
| export { foo }; |
5 changes: 5 additions & 0 deletions
5
...ge/module-code/ambiguous-export-bindings/namespace-import-star-as-and-export-2_FIXTURE.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| // Copyright (C) 2025 Igalia, S.L. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| import * as foo from "./namespace-empty-module_FIXTURE.js"; | ||
| export { foo }; |
79 changes: 79 additions & 0 deletions
79
...rt-bindings/namespace-unambiguous-if-export-star-as-from-and-import-star-as-and-export.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| // Copyright (C) 2025 Igalia, S.L. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
| /*--- | ||
| description: Exporting the same namespace object twice with `export * as foo` and `import * as foo; export { foo }` produces an unambiguous binding | ||
| esid: sec-source-text-module-record-initialize-environment | ||
| info: | | ||
| [...] | ||
| 7. For each ImportEntry Record in of module.[[ImportEntries]], do | ||
| a. Let importedModule be GetImportedModule(module, in.[[ModuleRequest]]). | ||
| b. If in.[[ImportName]] is namespace-object, then | ||
| i. Let namespace be GetModuleNamespace(importedModule). | ||
| ii. Perform ! env.CreateImmutableBinding(in.[[LocalName]], true). | ||
| iii. Perform ! env.InitializeBinding(in.[[LocalName]], namespace). | ||
| c. Else, | ||
| i. Let resolution be importedModule.ResolveExport(in.[[ImportName]]). | ||
| ii. If resolution is either null or ambiguous, throw a SyntaxError exception. | ||
|
|
||
| Table 59 (Informative): Export Forms Mappings to ExportEntry Records | ||
|
|
||
| Export Statement Form [[ExportName]] [[ModuleRequest]] [[ImportName]] [[LocalName]] | ||
| export * as ns from "mod"; "ns" "mod" all null | ||
|
|
||
| 16.2.1.7.1 ParseModule ( sourceText, realm, hostDefined ) | ||
| [...] | ||
| 10. For each ExportEntry Record ee of exportEntries, do | ||
| 1. If ee.[[ModuleRequest]] is null, then | ||
| i. If importedBoundNames does not contain ee.[[LocalName]], then | ||
| 1. Append ee to localExportEntries. | ||
| ii. Else, | ||
| 1. Let ie be the element of importEntries whose [[LocalName]] is ee.[[LocalName]]. | ||
| 2. If ie.[[ImportName]] is namespace-object, then | ||
| a. NOTE: This is a re-export of an imported module namespace object. | ||
| b. Append the ExportEntry Record { [[ModuleRequest]]: ie.[[ModuleRequest]], [[ImportName]]: ~all~, [[LocalName]]: *null*, [[ExportName]]: ee.[[ExportName]] } to indirectExportEntries. | ||
| 3. Else, | ||
| a. NOTE: This is a re-export of a single name. | ||
| b. Append the ExportEntry Record { [[ModuleRequest]]: ie.[[ModuleRequest]], | ||
| [[ImportName]]: ie.[[ImportName]], [[LocalName]]: null, [[ExportName]]: | ||
| ee.[[ExportName]] } to indirectExportEntries. | ||
| 2. Else if ee.[[ImportName]] is all-but-default, then | ||
| [...] | ||
| 3. Else, | ||
| a. Append ee to indirectExportEntries. | ||
|
|
||
| 15.2.1.16.3 ResolveExport | ||
|
|
||
| [...] | ||
| 6. For each ExportEntry Record e of module.[[IndirectExportEntries]], do | ||
| a. If e.[[ExportName]] is exportName, then | ||
| i. Assert: e.[[ModuleRequest]] is not null. | ||
| ii. Let importedModule be GetImportedModule(module, e.[[ModuleRequest]]). | ||
| iii. If e.[[ImportName]] is all, then | ||
| 1. Assert: module does not provide the direct binding for this export. | ||
| 2. Return ResolvedBinding Record { [[Module]]: importedModule, [[BindingName]]: namespace }. | ||
| [...] | ||
| 9. Let starResolution be null. | ||
| 10. For each ExportEntry Record e in module.[[StarExportEntries]], do | ||
| a. Let importedModule be GetImportedModule(module, | ||
| e.[[ModuleRequest]]). | ||
| b. Let resolution be ? importedModule.ResolveExport(exportName, | ||
| resolveSet, exportStarSet). | ||
| c. If resolution is ~ambiguous~, return ~ambiguous~. | ||
| d. If resolution is not null, then | ||
| i. If starResolution is null, let starResolution be resolution. | ||
| ii. Else, | ||
| 1. Assert: there is more than one * import that includes the | ||
| requested name. | ||
| 2. If _resolution_.[[Module]] and _starResolution_.[[Module]] are | ||
| not the same Module Record, return ~ambiguous~. | ||
| 3. If _resolution_.[[BindingName]] is not _starResolution_.[[BindingName]], | ||
| return ~ambiguous~. | ||
| flags: [module] | ||
| ---*/ | ||
|
|
||
| export * from "./namespace-export-star-as-from-1_FIXTURE.js"; | ||
| export * from "./namespace-import-star-as-and-export-1_FIXTURE.js"; | ||
|
|
||
| import { foo } from './namespace-unambiguous-if-import-star-as-and-export.js'; | ||
|
|
||
| assert.sameValue(typeof foo, 'object'); |
80 changes: 80 additions & 0 deletions
80
...age/module-code/ambiguous-export-bindings/namespace-unambiguous-if-export-star-as-from.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| // Copyright (C) 2025 Igalia, S.L. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
| /*--- | ||
| description: Exporting the same namespace object twice with `export * as foo` produces an unambiguous binding | ||
| esid: sec-source-text-module-record-initialize-environment | ||
| info: | | ||
| [...] | ||
| 7. For each ImportEntry Record in of module.[[ImportEntries]], do | ||
| a. Let importedModule be GetImportedModule(module, in.[[ModuleRequest]]). | ||
| b. If in.[[ImportName]] is namespace-object, then | ||
| i. Let namespace be GetModuleNamespace(importedModule). | ||
| ii. Perform ! env.CreateImmutableBinding(in.[[LocalName]], true). | ||
| iii. Perform ! env.InitializeBinding(in.[[LocalName]], namespace). | ||
| c. Else, | ||
| i. Let resolution be importedModule.ResolveExport(in.[[ImportName]]). | ||
| ii. If resolution is either null or ambiguous, throw a SyntaxError exception. | ||
|
|
||
| Table 59 (Informative): Export Forms Mappings to ExportEntry Records | ||
|
|
||
| Export Statement Form [[ExportName]] [[ModuleRequest]] [[ImportName]] [[LocalName]] | ||
| export {x}; "x" null null "x" | ||
| export * as ns from "mod"; "ns" "mod" all null | ||
|
|
||
| 16.2.1.7.1 ParseModule ( sourceText, realm, hostDefined ) | ||
| [...] | ||
| 10. For each ExportEntry Record ee of exportEntries, do | ||
| 1. If ee.[[ModuleRequest]] is null, then | ||
| i. If importedBoundNames does not contain ee.[[LocalName]], then | ||
| 1. Append ee to localExportEntries. | ||
| ii. Else, | ||
| 1. Let ie be the element of importEntries whose [[LocalName]] is ee.[[LocalName]]. | ||
| 2. If ie.[[ImportName]] is namespace-object, then | ||
| a. NOTE: This is a re-export of an imported module namespace object. | ||
| b. Append the ExportEntry Record { [[ModuleRequest]]: ie.[[ModuleRequest]], [[ImportName]]: ~all~, [[LocalName]]: *null*, [[ExportName]]: ee.[[ExportName]] } to indirectExportEntries. | ||
| 3. Else, | ||
| a. NOTE: This is a re-export of a single name. | ||
| b. Append the ExportEntry Record { [[ModuleRequest]]: ie.[[ModuleRequest]], | ||
| [[ImportName]]: ie.[[ImportName]], [[LocalName]]: null, [[ExportName]]: | ||
| ee.[[ExportName]] } to indirectExportEntries. | ||
| 2. Else if ee.[[ImportName]] is all-but-default, then | ||
| [...] | ||
| 3. Else, | ||
| a. Append ee to indirectExportEntries. | ||
|
|
||
| 15.2.1.16.3 ResolveExport | ||
|
|
||
| [...] | ||
| 6. For each ExportEntry Record e of module.[[IndirectExportEntries]], do | ||
| a. If e.[[ExportName]] is exportName, then | ||
| i. Assert: e.[[ModuleRequest]] is not null. | ||
| ii. Let importedModule be GetImportedModule(module, e.[[ModuleRequest]]). | ||
| iii. If e.[[ImportName]] is all, then | ||
| 1. Assert: module does not provide the direct binding for this export. | ||
| 2. Return ResolvedBinding Record { [[Module]]: importedModule, [[BindingName]]: namespace }. | ||
| [...] | ||
| 9. Let starResolution be null. | ||
| 10. For each ExportEntry Record e in module.[[StarExportEntries]], do | ||
| a. Let importedModule be GetImportedModule(module, | ||
| e.[[ModuleRequest]]). | ||
| b. Let resolution be ? importedModule.ResolveExport(exportName, | ||
| resolveSet, exportStarSet). | ||
| c. If resolution is ~ambiguous~, return ~ambiguous~. | ||
| d. If resolution is not null, then | ||
| i. If starResolution is null, let starResolution be resolution. | ||
| ii. Else, | ||
| 1. Assert: there is more than one * import that includes the | ||
| requested name. | ||
| 2. If _resolution_.[[Module]] and _starResolution_.[[Module]] are | ||
| not the same Module Record, return ~ambiguous~. | ||
| 3. If _resolution_.[[BindingName]] is not _starResolution_.[[BindingName]], | ||
| return ~ambiguous~. | ||
| flags: [module] | ||
| ---*/ | ||
|
|
||
| export * from "./namespace-export-star-as-from-1_FIXTURE.js"; | ||
| export * from "./namespace-export-star-as-from-2_FIXTURE.js"; | ||
|
|
||
| import { foo } from './namespace-unambiguous-if-export-star-as-from.js'; | ||
|
|
||
| assert.sameValue(typeof foo, 'object'); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.