Some fixes to maintain compliance to the styleguide #638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More TCs and TGs are expressing an interest in Ecmarkup, so I want to make sure we can produce the mandatory documents for them at standardization time.
Man I really hate the logic I came up with for the copyright page. Alternative: make sure it gets an easy-to-reference ID and move that back into the print.js DOM manipulation.
This is a draft because I’ve only glossed over the multipage output, haven’t given it a good look yet.This has all been checked on printable & multi-page ECMA-262 & ECMA-402 builds. I noticed no changes on multipage builds.
fixed
replaced blank cover
removed unexpected title page
replaced incorrectly formatted copyright notice—should match template
alternative
option added toboilerplate.copyright
for documents which use Ecma’s alternative copyrightformatted Annex titles as expected by template
needs extra scrutiny
I removed the code that moves the “scope” section to the beginning when printable option is passed. I didn’t see a spec that had the scope anywhere else, nor would I expect it. Maybe left over from when I was doing more manipulation on the prince side? Need a gut check that it’s good to go.
I changed the special treatment that the shortname gets when there’s a draft, as it breaks anything relying on the shortname being present. It shouldn’t impact multipage builds at all, but I suppose I could imagine a corner case where before changes to after
Before:
After:
The generated references are meaningfully different because of 👆🏻. Seeking an opinion on whether or not they should not be.