add a meta tag to set viewport options for mobile devices #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work, it was good seeing where you did this in here. I looked and thought such a big sweeping change to baselines might be a problem. |
michaelficarra
force-pushed
the
meta-viewport
branch
from
56d6d91 to
75f96f2
Compare
michaelficarra
force-pushed
the
meta-viewport
branch
from
75f96f2 to
9973221
Compare
bakkot
reviewed
Apr 9, 2025
| @@ -1,5 +1,5 @@ | |||
| <!doctype html> | |||
| <head><meta charset="utf-8"></head><body><div id="shortcuts-help"> | |||
| <head><meta name="viewport" content="width=device-width, initial-scale=1"><meta charset="utf-8"></head><body><div id="shortcuts-help"> | |||
There was a problem hiding this comment.
Kind of unfortunate this ends up being the second element but it's still close enough to the beginning of the file so it's probably fine.
bakkot
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally from tc39/ecma262#3481.