Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Automated lib version bumping #213

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

scott45
Copy link
Contributor

@scott45 scott45 commented Nov 11, 2024

SPDX-License-Identifier: Apache-2.0

What did we change?

Implement automated frms-coe-lib version bumping PRs in dependent repos

Why are we doing this?

To get away with manual versions bumping

How was it tested?

  • Locally
  • Development Environment
  • Not needed, changes very basic
  • Husky successfully run
  • Unit tests passing and Documentation done

@scott45 scott45 self-assigned this Nov 11, 2024
@github-actions github-actions bot added the CI/CD label Nov 11, 2024
@scott45 scott45 changed the title ci: Automated lib version bumping [WIP] ci: Automated lib version bumping Nov 11, 2024
GH_TOKEN: '${{ secrets.GH_TOKEN }}'
NODE_AUTH_TOKEN: '${{ secrets.NODE_AUTH_TOKEN }}'

sync-version-across-tazama-repos:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use dependabot instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rtkay123 is this something we're currently doing? I don't think I've seen dependabot being used for this use case but I'd like to if we're doing this.

Let us wait for what @cshezi thinks, I did have a chat with him on Friday before making these changes.

Context:

The frms-coe-lib and frms-coe-startup-lib versions don't reflect correctly in most rule processors except 901. If I also remember well, before the last release we manually created PRs to do the version bumping and all.

Briefly what these changes will do is ensure every time new versions of frms-coe-lib and frms-coe-startup-lib are published, a PR will be created in each repo that lists the lib as a dependency in package.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not currently doing that, but the change in my opinion should be in the dependabot config so that it's able to update frms-coe-lib and frms-coe-startup-lib.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to look into this today

Copy link
Contributor

@rtkay123 rtkay123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For easier maintenance, I think syncing versions should be done by dependabot. Thoughts @cshezi ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants