Remove callback guard #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one is up to @antoyo. :) (But 👍 for me) |
|
This deprecates stuff like this, but I can merge as is. |
|
@antoyo Hm, I don't see new deprecate in https://github.com/gtk-rs/webkit2gtk-rs/pull/38/files#diff-bd795c9f63abd67565668c302ff9fba4R90 |
|
@antoyo Now I understand, you meant, that it was in manual code. |
|
Normal mode need single_version_file too, missed that |
|
@EPashkin Here's the newly automatically generated |
|
I will remove duplicate |
EPashkin
force-pushed
the
remove_callback_guard
branch
from
5ac67cd to
d3c6076
Compare
|
Updated with temporary version |
|
Looks good. |
|
I thought that some warnings left. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of gtk-rs/glib#250
cc @GuillaumeGomez, @antoyo