Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add Manager::run_on_main_thread/run_on_main_thread_return, remove old explicit methods #12893

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

amrbashir
Copy link
Member

No description provided.

…in_thread_return`, remove old explicit methods
@amrbashir amrbashir requested a review from a team as a code owner March 5, 2025 01:52
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Package Changes Through 231e922

There are 5 changes which include tauri with major, @tauri-apps/api with minor, tauri-runtime-wry with minor, tauri-cli with patch, @tauri-apps/cli with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.3.0 2.4.0
tauri-runtime-wry 2.4.1 2.5.0
tauri 2.3.1 3.0.0
@tauri-apps/cli 2.3.1 2.3.2
tauri-cli 2.3.1 2.3.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@amrbashir amrbashir changed the title feat(core): add Manager::run_on_main_thread and Manager::run_on_main_thread_return, remove old explicit methods feat(core): add Manager::run_on_main_thread/run_on_main_thread_return, remove old explicit methods Mar 5, 2025
@amrbashir amrbashir moved this from 📬Proposal to 🏗 In progress in Roadmap Mar 5, 2025
@amrbashir amrbashir added this to 3.0 Mar 5, 2025
@amrbashir amrbashir removed this from Roadmap Mar 5, 2025
@amrbashir amrbashir moved this to In progress in 3.0 Mar 5, 2025
@amrbashir
Copy link
Member Author

Just opening so I don't forget, this should wait for v3

@FabianLars FabianLars added the type: breaking change This issue or pull request will introduce a breaking change and requires major version bump label Mar 5, 2025
@Legend-Master
Copy link
Contributor

As we're here, perhaps we can also get rid of shared_app_impl!? Rust analyzer basically don't work when writing things inside of it

Also maybe WebviewWindow and WebviewWindowBuilder? We can make a trait Webview and Window and implement things there so we don't have to duplicate things every time we add something in it

If you guys think it's a good idea, I'll put it on 3.0 so at least we don't permanently forget about it

@amrbashir
Copy link
Member Author

Yeah, I have been wanting to do that for quite some time but don't have the time just yet. This would need to have tauri::prelude module with it.

@lucasfernog
Copy link
Member

run_on_main_thread_blocking would be a name that matches with our dialog plugin APIs

@lucasfernog lucasfernog marked this pull request as draft March 14, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking change This issue or pull request will introduce a breaking change and requires major version bump
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

4 participants