feat(bundler): Truly portable appimage (experimental) #12491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 6bc146bThere are 5 changes which include tauri with minor, @tauri-apps/api with minor, tauri-runtime-wry with minor, tauri-cli with patch, @tauri-apps/cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Samueru-sama
reviewed
Mar 9, 2025
Samueru-sama
reviewed
Mar 9, 2025
| @@ -151,7 +151,7 @@ pub fn bundle_project(settings: &Settings) -> crate::Result<Vec<PathBuf>> { | |||
| .args([ | |||
| "-c", | |||
| &format!( | |||
| r#"{} -p {} -r {} -k {} \ | |||
| r#"{} -p {} {} -k {} \ | |||
There was a problem hiding this comment.
Doesn't the {} also need to be removed? 👀 I'm don't know rust though.
There was a problem hiding this comment.
that's for the strip flag (wanted to support a NO_STRIP env var in our bundler). i was confused at first as well 😅
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will add description later