Feat/add skip waiting connection option #3027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
reviewed
Jan 26, 2025
| this.connection = new Connection(opts.connection, { | ||
| shared: isRedisInstance(opts.connection), | ||
| blocking: false, | ||
| skipVersionCheck: opts.skipVersionCheck, |
There was a problem hiding this comment.
shouldn't we allow to pass skipWaitingForRead here too as flowProducer could be used to add jobs as queue class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When failing fast if the connection is not available, it is sometimes also needed to fail in the case the initial connection has not yet being stablished with Redis. More background can be found here: #995
How
We introduced a new option "skipWaitingForReady" that is by default false, to keep the old behaviour and no introduce breaking changes.
Additional Notes (Optional)