Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(job): add moveToWait method for manual processing #2978

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented Dec 20, 2024

When manually rate limiting a job, in manual processing pattern this method was missed to be exposed

@roggervalf roggervalf force-pushed the feat-manual-move-to-wait branch from 39be1f2 to e9d1f3e Compare December 24, 2024 23:25
Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't we also need to update the documentation on how to use this method?

@roggervalf roggervalf force-pushed the feat-manual-move-to-wait branch from 74f1ca1 to 09383d9 Compare December 31, 2024 17:05
@roggervalf
Copy link
Collaborator Author

Wouldn't we also need to update the documentation on how to use this method?

Already added

@roggervalf roggervalf force-pushed the feat-manual-move-to-wait branch 3 times, most recently from 3ac3172 to ddf7dc4 Compare January 12, 2025 16:39
@roggervalf roggervalf force-pushed the feat-manual-move-to-wait branch 2 times, most recently from 4e9abd6 to 0a1391b Compare January 14, 2025 02:00
@roggervalf roggervalf force-pushed the feat-manual-move-to-wait branch 4 times, most recently from 4a0d8f7 to 5e22eca Compare January 25, 2025 03:32
@roggervalf roggervalf force-pushed the feat-manual-move-to-wait branch from 5e22eca to 3ba7be2 Compare February 14, 2025 04:37
Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roggervalf roggervalf merged commit 5a97491 into master Feb 14, 2025
11 checks passed
@roggervalf roggervalf deleted the feat-manual-move-to-wait branch February 14, 2025 14:11
github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
# [5.41.0](v5.40.5...v5.41.0) (2025-02-14)

### Features

* **job:** add moveToWait method for manual processing ([#2978](#2978)) ([5a97491](5a97491))
* **queue:** support removeGlobalConcurrency method ([#3076](#3076)) ([ece8532](ece8532))

### Performance Improvements

* **add-job:** add job into wait or prioritized state when delay is provided as 0 ([#3052](#3052)) ([3e990eb](3e990eb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants