Convert voluptuous schema to msgspec #752
Conversation
…aph into schema-conversion
abhishekmadan30
changed the title
abhishekmadan30
changed the title
abhishekmadan30
added
the
BREAKING CHANGE
| # Additional fields handled dynamically by fetch builders | ||
|
|
||
|
|
||
| class FetchSchema(Schema): |
There was a problem hiding this comment.
I've noticed you sometimes use FooSchema, sometimes FooConfig and sometime neither. It would be good to be consistent across all schema class names.
Personally I think I like FooSchema the best (even for things that are sub schemas). Though happy to bikeshed with you if you have another preference.
...utter.project_name}}/taskcluster/{{cookiecutter.project_slug}}_taskgraph/transforms/hello.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Nice, thanks for the updates! I don't see any fundamental problems or anything, though I'll reserve the right to request future changes as we test this out in Gecko ;)
I'll avoid approving this for now because I want to hold off landing until we have a working patch for Gecko, but I think you can go ahead and get started on that! Hopefully claude or some clever macros can help with the conversion, because there's going to be a lot of schemas :)
No description provided.