Add Bulletproof rewind functionality #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's probably worth submitting this PR to the source repo as well, then hopefully they take a look and merge it or have any feedback |
We have, we are doing this so we can use the fork until we finish our discussions with them. |
|
Sorry! I didn't realize it was already submitted. That's my bad |
philipr-za
reviewed
Nov 27, 2020
Actually not submitted, just the issue that has been registered. It also needs to be rebased on top of their dev branch to be submitted. |
This is closely modelled on Grin's soliution, but using two private keys:
- Interfaces:
- create a rewindable ZK proof with up to 23 bytes additional embedded proof
data
- extract the value and 23 bytes proof data only
- extract the value, blinding factor and 23 bytes proof data
- Required:
- two rewind nonces, based on a two public rewind keys and the value
commitment
- two blinding nonces, based on the two private rewind keys and the value
commitment
- Use:
- the two rewind nonces are used to extract the value and 23 bytes embedded
proof data
- the two rewind nonces and two blinding nonces are used to extract the
value, blinding factor and 23 bytes embedded proof data
hansieodendaal
force-pushed
the
investigate_rewind
branch
from
d775d5a to
6e820b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is closely modelled on Grin's solution, but using two private keys:
commitment
commitment
data
value, blinding factor and 23 bytes embedded data
See related Dalek issue dalek-cryptography#335