Skip to content

Support UUID extended type #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

DifferentialOrange
Copy link
Member

@DifferentialOrange DifferentialOrange commented Aug 31, 2022

Merge after #226

Tarantool supports UUID type since version 2.4.1 [1]. This patch introduced the support of Tarantool UUID type in msgpack decoders and encoders. The Tarantool UUID type is mapped to the native Python uuid.UUID type.

  1. Introduce new type for UUID tarantool#4268

Closed #202

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-202-uuid branch from c011e2f to 9607578 Compare August 31, 2022 12:49
@DifferentialOrange DifferentialOrange changed the title msgpack: support UUID extended type Support UUID extended type Aug 31, 2022
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-203-decimal branch 2 times, most recently from 6119a53 to e67666a Compare September 1, 2022 07:00
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-202-uuid branch from 9607578 to 1e57e7b Compare September 1, 2022 07:05
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-203-decimal branch from e67666a to 4205a21 Compare September 1, 2022 10:27
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-202-uuid branch from 1e57e7b to 747995c Compare September 1, 2022 10:28
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-203-decimal branch 4 times, most recently from b994b01 to 71559ad Compare September 1, 2022 17:32
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-202-uuid branch 2 times, most recently from df7f4f9 to 3ac6206 Compare September 2, 2022 06:54
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-203-decimal branch from 71559ad to 45c5b34 Compare September 5, 2022 07:42
@DifferentialOrange DifferentialOrange changed the base branch from DifferentialOrange/gh-203-decimal to master September 5, 2022 13:39
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-202-uuid branch from 3ac6206 to 989af6c Compare September 5, 2022 13:46
@DifferentialOrange DifferentialOrange marked this pull request as ready for review September 5, 2022 14:09
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch! LGTM, but I would split test_msgpack_ext.py into two files. It may become too big in the future.

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-202-uuid branch from 989af6c to 7181eb0 Compare September 7, 2022 11:54
@DifferentialOrange
Copy link
Member Author

but I would split test_msgpack_ext.py into two files.

Reworked

Tarantool supports UUID type since version 2.4.1 [1]. This patch
introduced the support of Tarantool UUID type in msgpack decoders and
encoders. The Tarantool UUID type is mapped to the native Python
uuid.UUID type.

1. tarantool/tarantool#4268

Closed #202
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-202-uuid branch from 7181eb0 to 51ece90 Compare September 7, 2022 12:03
@DifferentialOrange DifferentialOrange merged commit c70dfa6 into master Sep 7, 2022
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/gh-202-uuid branch September 7, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support UUID
2 participants