api: fix address already in use error #36
Merged
+259
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themilchenko
force-pushed
the
themilchenko/gh-33-fix-address-already-in-use
branch
3 times, most recently
from
e763de0 to
25eb1c3
Compare
DerekBum
reviewed
Apr 17, 2025
themilchenko
force-pushed
the
themilchenko/gh-33-fix-address-already-in-use
branch
3 times, most recently
from
f420690 to
047fafb
Compare
themilchenko
force-pushed
the
themilchenko/gh-33-fix-address-already-in-use
branch
from
047fafb to
66281f8
Compare
themilchenko
force-pushed
the
themilchenko/gh-33-fix-address-already-in-use
branch
2 times, most recently
from
785694c to
0f65466
Compare
|
I have fixed things we talked before. Now we search for unused servers on each apply and stop it before creating and editing new ones. PR is ready for the next review. |
themilchenko
force-pushed
the
themilchenko/gh-33-fix-address-already-in-use
branch
from
0f65466 to
0181f24
Compare
themilchenko
force-pushed
the
themilchenko/gh-33-fix-address-already-in-use
branch
from
0181f24 to
a0ea4a1
Compare
DifferentialOrange
approved these changes
Apr 27, 2025
themilchenko
force-pushed
the
themilchenko/gh-33-fix-address-already-in-use
branch
from
a0ea4a1 to
f916e64
Compare
DifferentialOrange
approved these changes
Apr 28, 2025
DerekBum
approved these changes
Apr 28, 2025
There was a bug when user wants to change server's `listen` address and reload config on the fly - error `address already in use` occures. This patch reworks server's address handling: now it checks if the new config contains existing servers, and stops unused ones if not. Closes #34
themilchenko
force-pushed
the
themilchenko/gh-33-fix-address-already-in-use
branch
from
f916e64 to
70f8d6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug when user wants to change server's
listenaddress and reload config on the fly - erroraddress already in useoccures.This patch reworks server's address handling by applying roles' config.
Closes #34