Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RPM spec to require recent Tarantool versions #68

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

viciious
Copy link
Contributor

@viciious viciious commented Nov 6, 2020

Update Tarantool version requirement to 1.10 along the way: see 702d673

Not sure about the libsmall discrepancies: please see #59 and #60

@viciious viciious force-pushed the update_rpm branch 2 times, most recently from cb54f59 to a83c873 Compare November 6, 2020 09:20
@Totktonada
Copy link
Member

Nice catch! I would do the same in debian/control. If you don't mind, I'll also include the details you provided in the PR description into the commit message.

@viciious
Copy link
Contributor Author

viciious commented Nov 9, 2020

No, I don't mind ofc. Would you prefer me to amend the commit message?

@Totktonada
Copy link
Member

Does not matter much. I'll do.

@viciious
Copy link
Contributor Author

viciious commented Nov 11, 2020

What about the cyrus-sasl dependency? Shouldn't it also have its own Requires: statement in the spec file? The same question applies to cyrus-sasl-lib

@Totktonada
Copy link
Member

What about the cyrus-sasl dependency? Shouldn't it also have its own Requires: statement in the spec file? The same question applies to cyrus-sasl-lib

It seems, automatic dependencies on shared libraries (as ldd reports) should do the work:

$ PACKAGECLOUD_USER=tarantool PACKAGECLOUD_REPO=1_10 OS=el DIST=7 ~/p/t/packpack/packpack
$ rpm --query --requires build/tarantool-memcached-1.0.1.2-1.el7.x86_64.rpm
error: Macro %__python has empty body
ld-linux-x86-64.so.2()(64bit)
ld-linux-x86-64.so.2(GLIBC_2.3)(64bit)
libc.so.6()(64bit)
libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libsasl2.so.3()(64bit)
libsmall.so.1()(64bit)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rtld(GNU_HASH)
tarantool >= 1.6.8.0
rpmlib(PayloadIsXz) <= 5.2-1

The libsasl2.so.3()(64bit) dependency is provided by the cyrus-sasl-lib package (at least on CentOS 7).

https://rpm.org/user_doc/more_dependencies.html#automatic-dependencies
https://www.debian.org/doc/debian-policy/ch-sharedlibs.html#generating-dependencies-on-shared-libraries

Update Tarantool version requirement to 1.10
@viciious viciious changed the title Update RPM spec file to match the rockspec Update RPM spec to require recent Tarantool versions Nov 12, 2020
@Totktonada
Copy link
Member

I'll update debian/control in a separate PR to don't reword the commit message.

@Totktonada Totktonada merged commit 1f6d7b0 into tarantool:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants