cluster: expel instances removed from config in cluster.sync #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
reviewed
Jun 23, 2025
locker
changed the title
Totktonada
approved these changes
Jul 23, 2025
Currently, cluster:sync() leaves instances removed from the config in the instance list. This makes cluster:reload() fail because it tries to reload the config for all instances including those that are not in the config anymore. To fix that, let's make cluster:sync() move instances that were removed from the config to the special expelled instance list so that they become inaccessible via cluster but are still dropped by cluster:drop(). Also, let's add the new boolean option start_stop for cluster:sync(). If set, cluster:sync() will stop old servers and start new ones. Closes tarantool#423
Totktonada
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
cluster:sync()leaves instances removed from the config in the instance list. This makescluster:reload()fail because it tries to reload the config for all instances including those that are not in the config anymore. To fix that, let's makecluster:sync()move instances that were removed from the config to the special expelled instance list so that they become inaccessible via cluster but are still dropped bycluster:drop().Also, let's add the new boolean option
start_stopforcluster:sync(). If set,cluster:sync()will stop old servers and start new ones.Closes #423