Skip to content

feat: quality of service #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: quality of service #1006

wants to merge 7 commits into from

Conversation

Tjemmmic
Copy link
Contributor

Overview

  • Implements heartbeat logic and storage for Blueprints in Services pallet

Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if we're requiring operators to submit heartbeats then we ought to consider what happens when enough heartbeats are missed. What does the ImOnline pallet do @1xstj that we can maybe copy here? We can be generous and allow heartbeats to be missed but if we have like 10 heartbeats in a row missed or <90% uptime in a session then we consider that bad.

Continuing on the last point, we could leverage this to create some sort of SLA guarantee or slash occurs. Would the customer request a certain SLA and cause the interval of heartbeats to change for specific service? I think @Tjemmmic it's worth considering that we might even want fine-grained intervals and other config per service.

Great start nonetheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants