Skip to content

docs(supervise): Runtime admits a child budget of any size; record the removed floor - #2695

Merged
drewstone merged 1 commit into
mainfrom
fix/budget-floor-2694
Nov 17, 2026
Merged

drewstone merged 1 commit into
mainfrom
fix/budget-floor-2694

Conversation

@drewstone

Copy link
Copy Markdown
Member

Closes #2694. This PR changes docs only, so nothing is released.

Decision: the floor's removal was deliberate and right

Deliberate. #736 removed the floor in sub-commit aafd2a1, "fix(supervise): remove guessed worker token floor". That commit also rewrote the agent-graphs skill to say why: "Do not turn one run's cumulative spend into a universal harness minimum; Runtime enforces the caller's conserved pool, not guessed per-harness floors." The #736 thread never discusses it, and the CHANGELOG never recorded it. This PR adds the missing CHANGELOG line.

Right.

  • The number was not a per-iteration floor. 31,211 was the lowest cumulative input-token settlement among six pi children on one model (tangle-router/glm-5.2), each running 1 to 4 iterations.
  • It keyed on the wrong thing. The table enforced that number for every pi child on every model, and every other harness was null. refactor(runtime): enforce canonical model execution boundary #736 made the exact AgentProfile the only execution authority. The cost of a turn follows the profile's model, prompt, tools and mounted context, not the harness name. A harness-keyed constant would refuse a lean profile and admit a heavy one.
  • The failure it targeted is now recovered in other ways. fix(supervise): refuse a child budget below the harness's measured floor #685's case was a child that wrote its artifact, then overran its budget and was recorded as a failure.
    • An overrun now settles done with its output and a budgetViolation.
    • Since feat(spawn): a keyed worker stopped by its budget keeps its session for a same-key continuation #1898, a keyed child with a retained environment keeps that environment held. Re-spawning the key with a larger budget continues the same session. tests/kernel/leaf-unavailable-pause.test.ts > "keeps its box, and a same-key re-spawn with a budget continues the session in it" proves this: a 1-token budget is admitted, the 5-token turn settles done with a violation, and a larger budget continues in the same box and session.

Change

  • docs/agent-managed-compute/reliability.md now states what Runtime does today:
    • It admits any child budget the pool can reserve.
    • It has no per-harness minimum.
    • An overrun keeps its output, and a keyed retained child can continue.
    • preflightSpawn sees the profile and task but not the budget, so callers size budgets from measured runs of the same profile.
  • CHANGELOG.md 0.129.0 now records the removal of below-runtime-floor from ReservationRejection and SpawnRejection.

Proof

Gate on a90f627, exit 0: beelink-gate auto ... -- pnpm run docs:check && pnpm exec vitest run tests/kernel/leaf-unavailable-pause.test.ts. Docs freshness OK, generated API docs unchanged, 21/21 tests passed.

Run ID: run_57c89af437fe21306e903f04976cae00

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T22:46:05.887129Z a90f627 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — a90f627d

Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-11-17T22:45:36Z

@drewstone
drewstone merged commit 53d6ad6 into main Nov 17, 2026
1 check passed
@drewstone
drewstone deleted the fix/budget-floor-2694 branch November 17, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Child token budgets below one iteration's cost are no longer refused (#736 removed the floor; no replacement or changelog note)

2 participants