Repository navigation
docs(supervise): Runtime admits a child budget of any size; record the removed floor - #2695
Merged
Merged
Conversation
…no per-harness floor (#2694)
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tangletools
approved these changes
Nov 17, 2026
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved PR — a90f627d
Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-11-17T22:45:36Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2694. This PR changes docs only, so nothing is released.
Decision: the floor's removal was deliberate and right
Deliberate. #736 removed the floor in sub-commit aafd2a1, "fix(supervise): remove guessed worker token floor". That commit also rewrote the
agent-graphsskill to say why: "Do not turn one run's cumulative spend into a universal harness minimum; Runtime enforces the caller's conserved pool, not guessed per-harness floors." The #736 thread never discusses it, and the CHANGELOG never recorded it. This PR adds the missing CHANGELOG line.Right.
pichildren on one model (tangle-router/glm-5.2), each running 1 to 4 iterations.pichild on every model, and every other harness wasnull. refactor(runtime): enforce canonical model execution boundary #736 made the exactAgentProfilethe only execution authority. The cost of a turn follows the profile's model, prompt, tools and mounted context, not the harness name. A harness-keyed constant would refuse a lean profile and admit a heavy one.donewith its output and abudgetViolation.tests/kernel/leaf-unavailable-pause.test.ts> "keeps its box, and a same-key re-spawn with a budget continues the session in it" proves this: a 1-token budget is admitted, the 5-token turn settlesdonewith a violation, and a larger budget continues in the same box and session.Change
docs/agent-managed-compute/reliability.mdnow states what Runtime does today:preflightSpawnsees the profile and task but not the budget, so callers size budgets from measured runs of the same profile.CHANGELOG.md0.129.0 now records the removal ofbelow-runtime-floorfromReservationRejectionandSpawnRejection.Proof
Gate on a90f627, exit 0:
beelink-gate auto ... -- pnpm run docs:check && pnpm exec vitest run tests/kernel/leaf-unavailable-pause.test.ts. Docs freshness OK, generated API docs unchanged, 21/21 tests passed.Run ID: run_57c89af437fe21306e903f04976cae00