Skip to content

rc/8.0.0#216

Open
martinzigrai wants to merge 23 commits into
masterfrom
rc/7.6.0
Open

rc/8.0.0#216
martinzigrai wants to merge 23 commits into
masterfrom
rc/7.6.0

Conversation

@martinzigrai
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

@tompsota tompsota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing: There are no tests for SuspiciousAppDetectionConfig, MalwareScanScope, ScopeType, or ReasonMode. Every other model in lib/src/models/ has a corresponding test/src/models/*_test.dart covering construction, toJson, fromJson, and edge cases (see test/src/models/android_config_test.dart lines 45–91 for the established pattern).

Also missing: an AndroidConfig test exercising the suspiciousAppDetectionConfig field in both fromJson/toJson directions

Can you just generate some simple test cases?

If the requested changes here are relevant also for other repos, please update those as well.

Comment thread example/lib/main.dart Outdated
Comment thread CHANGELOG.md Outdated
Comment thread lib/src/models/android_config.dart Outdated
Comment thread lib/src/models/android_config.g.dart
Comment thread android/src/main/kotlin/com/aheaditec/freerasp/Extensions.kt Outdated
Comment thread android/src/main/kotlin/com/aheaditec/freerasp/Extensions.kt Outdated
Comment thread android/src/main/kotlin/com/aheaditec/freerasp/Extensions.kt Outdated
Comment thread lib/src/models/suspicious_app_detection_config.dart
Comment thread android/src/main/kotlin/com/aheaditec/freerasp/Extensions.kt Outdated
Comment thread android/src/main/kotlin/com/aheaditec/freerasp/Extensions.kt Outdated
@martinzigrai
Copy link
Copy Markdown
Contributor Author

Added tests for SuspiciousAppDetectionConfig, MalwareScanScope, ScopeType, ReasonMode plus AndroidConfig coverage for the suspiciousAppDetectionConfig field.

@martinzigrai martinzigrai changed the title Rc/7.6.0 rc/8.0.0 May 13, 2026
Comment thread example/lib/main.dart Outdated
martinzigrai and others added 3 commits May 18, 2026 18:20
Rename the `scanScope: ScopeType` field inside the `ScanScope` class to
`scopeType` so the field name matches its type name. Update the generated
g.dart, JSON key, default config, example app, Kotlin native bridge, and
all tests accordingly.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tompsota tompsota added the release Create a new release on GH and publish package label May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Create a new release on GH and publish package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants