Skip to content

Conversation

arsarsars1
Copy link

  • Added accessibility enhancements to ensure compatibility with the iOS platform.
  • Fixed Firebase authentication to work seamlessly on both iOS and Android platforms.
  • Removed flutter_apns dependency as it was causing disconnection issues.

- fix the firebase auth to run on both platforms
- removed flutter_apns because it disconnected
@bugnano
Copy link
Collaborator

bugnano commented Jul 3, 2023

First of all thank you for your contribution.
Before being able to accept any PR, no matter how small, we require every contributor to sign either the Individual CLA or the corporate CLA that you find in this repo, and email it to [email protected]

Having said that, there are a couple of things that I don't like in this PR:

  1. Please don't reformat the sources, as it makes it nearly impossible to understand what are actual changes, and what are only automated formatting changes
  2. We don't use Firebase for push notifications on iOS, so removing the flutter_apns dependency results in breaking the push notifications on iOS

@arsarsars1
Copy link
Author

arsarsars1 commented Jul 3, 2023 via email

@arsarsars1
Copy link
Author

arsarsars1 commented Jul 3, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants