-
-
Notifications
You must be signed in to change notification settings - Fork 112
feat: add kubernetes deployment configuration using helm #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: jcstryker <[email protected]>
|
For reference I added some stuff on top of @antoniolago's repo here I only was trying to get things working, use my changes however you would like or not at all :) |
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
This commit removes the unused PersistentVolumeClaim templates for headplane and headscale components. The templates were left in place but contained only a TODO comment, indicating they were not yet implemented. Removing them cleans up the codebase and prevents confusion about their intended purpose. The pvc templates were previously defined in the kubernetes/headplane/templates/headplane/pvc.yaml and kubernetes/headplane/templates/headscale/pvc.yaml files but were not actually needed for the current implementation. This change reduces code clutter and improves maintainability by removing dead code. Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
…scale This commit introduces the missing PersistentVolumeClaim templates for both headplane and headscale components. The changes implement the full PVC specification with support for: - Custom annotations and labels - Configurable access modes - Storage requests - Storage class configuration The templates follow the existing pattern used in the helm chart and are conditionally enabled based on the persistence configuration values. This provides the necessary storage persistence for both services when enabled. The implementation includes proper templating with Helm syntax to ensure compatibility with the chart's configuration system. Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
|
@tale this should be ready for review now |
tale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, the last thing I want to know is how can I deploy this as an OCI native chart so that we can use the oci:// prefix and also what documentation would look like for using the Helm chart.
| description: Kubernetes Helm Chart for Headplane in integrated mode | ||
| name: headplane | ||
| type: application | ||
| version: 1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| version: 1.0.0 | |
| version: 0.1.0 |
v1 chart when not even the app is v1 yet is awkward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we match it to our SEMver?
tale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semver nit
This PR resolves #55
Alternative Helm chart to the chart provided here https://github.com/nbcloudio/headplane-chart - I have some concerns around best practices and security - feeling it best to start from scratch to also resolve licensing concerns.
This is provided to this project under the MIT licence.
Thank you to
@antoniolago for doing some fantastic work updating that chart from nbcloudio
@definitelynobody for some further enhancements to the nbcloudio chart - I did not adapt anything directly for this first version of the chart but happy to take a look and help bring some of those features in the future
I have tested OIDC Login, Persistence, Admin Login, Database-backed ACLs - I am successfully serving 5-10 devices covering common use cases like exit nodes with this chart in my Homelab.
Notably missing is the tailscale relay feature from the @nbcloudio/@antoniolago/@definitelynobody version of the chart.
I am happy to look into adding that feature in a followup PR once I have time to understand what it does, or someone else can take that enhancement.
example
values.yamlused for testingFollow Up PR ideas: