Skip to content

Update style.css #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Update style.css #14

merged 1 commit into from
Jul 9, 2024

Conversation

Imran-imtiaz48
Copy link
Contributor

Changes made:

  1. Updated height: 50% to height: 100% in the .split class to ensure it covers the full height.
  2. Combined background properties for .split.left and .split.right to use shorthand notation for better readability.
  3. Ensured consistent indentation and formatting.
  4. Verified the logic and transitions to maintain visual coherence across different screen sizes.

Changes made:
1.	Updated height: 50% to height: 100% in the .split class to ensure it covers the full height.
2.	Combined background properties for .split.left and .split.right to use shorthand notation for better readability.
3.	Ensured consistent indentation and formatting.
4.	Verified the logic and transitions to maintain visual coherence across different screen sizes.
@tajulafreen
Copy link
Owner

Hey @Imran-imtiaz48,
Thanks for taking the time to contribute to these improvements!

Your changes to the .split class are great - ensuring the full height is covered and using shorthand for the background properties makes the code cleaner and easier to read.

It's also awesome that you've carefully considered the logic and transitions to ensure the design looks great on different screen sizes.

I really appreciate your attention to detail and your contributions to the project!

@tajulafreen tajulafreen merged commit 4995fd2 into tajulafreen:main Jul 9, 2024
5 checks passed
@Imran-imtiaz48
Copy link
Contributor Author

Thank you for your kind words and detailed feedback! I'm glad to hear that the changes to the .split class and the use of shorthand for the background properties are appreciated.

Ensuring the design looks great on different screen sizes was a key focus, so I'm pleased that it met the project's needs.

I look forward to contributing more and continuing to improve the project!

Best,
Imran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants