Skip to content

acl: match ACL patterns without allocation #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

acl: match ACL patterns without allocation #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 2 additions & 26 deletions acl/acl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,7 @@
// ACL policies are provided by tailscale peer capabilities.
package acl

import (
"fmt"
"regexp"
"strings"
)
import "github.com/creachadair/mds/mstr"

// Action is an action on secrets that is subject to access control.
type Action string
Expand Down Expand Up @@ -45,27 +41,7 @@ const (
type Secret string

// Match reports whether the Secret name pattern matches val.
func (pat Secret) Match(val string) bool {
s := string(pat)
if !strings.Contains(s, "*") && s == val {
return true
}
// We want the user to use glob-ish syntax, where '*' is the
// equivalent of regexp's '.*'. We also don't want any other
// character of the input misinterpreted as a regexp control
// character.
//
// To achieve this, we:
// - split each input string on '*'
// - regexp-quote the resulting parts
// - reassemble the quoted parts around '.*' separators
parts := strings.Split(s, "*")
for i := range parts {
parts[i] = regexp.QuoteMeta(parts[i])
}
re := regexp.MustCompile(fmt.Sprintf("^%s$", strings.Join(parts, ".*")))
return re.MatchString(val)
}
func (pat Secret) Match(val string) bool { return mstr.Match(val, string(pat)) }

// Rules is a set of ACLs for access to a secret.
type Rules []Rule
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ require (
github.com/aws/aws-sdk-go-v2/service/sts v1.33.13
github.com/creachadair/command v0.1.22
github.com/creachadair/flax v0.0.4
github.com/creachadair/mds v0.25.2
github.com/creachadair/mds v0.25.4
github.com/creachadair/msync v0.5.6
github.com/google/go-cmp v0.7.0
github.com/tink-crypto/tink-go-awskms v0.0.0-20230616072154-ba4f9f22c3e9
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ github.com/creachadair/command v0.1.22 h1:WmdrURwZdmPD1jm13SjKooaMoqo7mW1qI2BPCS
github.com/creachadair/command v0.1.22/go.mod h1:YFc+OMGucqTpxwQg/iJnNg8BMNmRPDK60rYy8ckgKwE=
github.com/creachadair/flax v0.0.4 h1:6JYUw/MK85Tw9f99n1PBBfLWYrxQkfrgWP4A6zf4XhE=
github.com/creachadair/flax v0.0.4/go.mod h1:F1PML0JZLXSNDMNiRGK2yjm5f+L9QCHchyHBldFymj8=
github.com/creachadair/mds v0.25.2 h1:xc0S0AfDq5GX9KUR5sLvi5XjA61/P6S5e0xFs1vA18Q=
github.com/creachadair/mds v0.25.2/go.mod h1:+s4CFteFRj4eq2KcGHW8Wei3u9NyzSPzNV32EvjyK/Q=
github.com/creachadair/mds v0.25.4 h1:rUQqf9ihePG8fhppXohLSY+AdOljU4oYyWVDhWiWhyE=
github.com/creachadair/mds v0.25.4/go.mod h1:4hatI3hRM+qhzuAmqPRFvaBM8mONkS7nsLxkcuTYUIs=
github.com/creachadair/msync v0.5.6 h1:nRvdyfVNNeMndcYDb+Ui8tSeefYXTUI1G7zPzosld6Q=
github.com/creachadair/msync v0.5.6/go.mod h1:cHf8G0YBAfVk619K3RT7UARb8n6HAOCj0SZf4oUNkyM=
github.com/creack/pty v1.1.23 h1:4M6+isWdcStXEf15G/RbrMPOQj1dZ7HPZCGwE4kOeP0=
Expand Down