fix dial checking the wrong error #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Revisions
✅ AI review completed for r1 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at [email protected]. |
ghost
reviewed
Jun 2, 2025
| @@ -405,7 +405,7 @@ func TsnetDial(sd C.int, network, addr *C.char, connOut *C.int) C.int { | |||
| if err != nil { | |||
| return s.recErr(err) | |||
| } | |||
| if newConn(s, netConn, connOut); err != nil { | |||
| if err := newConn(s, netConn, connOut); err != nil { | |||
There was a problem hiding this comment.
This is a good fix. The original code was checking the wrong error variable - it was using the outer scope 'err' from the s.s.Dial call instead of capturing the error returned by newConn(). This could have led to silently ignoring errors from newConn() while incorrectly reporting errors from the Dial operation that had actually succeeded.
There was a problem hiding this comment.
I don't think it was falsely reporting errors for something that succeeds, but it possibly wasn't reporting errors for failures in newConn
There was a problem hiding this comment.
@crawshaw I think this was yours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging file descriptor leak while calling dial on udp multiple times, for multiple addresses in a loop. Ran into this.