Conversation
bradfitz
approved these changes
Jan 15, 2026
hallpass.go
Outdated
| webhookSecret = flag.String("webhook-secret", keyPath("hallpass-webhook"), "name of setec secret containing the Slack webhook URL; if --secret-server is empty, ignored and reads from $HOME/keys/hallpass-webhook") | ||
| configDir = flag.String("tsnet-dir", "", "tsnet server directory; if empty, tsnet uses an automatic config directory based on the binary name") | ||
| tls = flag.Bool("tls", true, "serve over TLS using Tailscale Serve") | ||
| loginServer = flag.String("login-server", "", "URL of control server to use for tsnet") |
Member
There was a problem hiding this comment.
"optional alternate URL of control server to use" ?
"optional alternate URL of control server" ?
(the "for tsnet" part seems unnecessary too)
but main part is to say it's optional
Signed-off-by: Bailey Jayes <bailey@solnet.lgbt>
bailey-ts
force-pushed
the
bailey-ts/loginserver
branch
from
6924dba to
d3cdd38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.