Conversation
As an alternative to reading a static OAuth secret from setec, allow using workload identity to authenticate to the API and set node attributes. If `--wif-client-id` and `--wif-audience` are set and `--oauth-secret` is empty, get the identity token from environment and use it for token exchange with the provided audience. Updates tailscale/corp#36612
mpminardi
reviewed
Feb 11, 2026
| Auth: &tailscale.IdentityFederation{ | ||
| ClientID: s.wifClientID, | ||
| IDTokenFunc: func() (string, error) { | ||
| return wif.ObtainProviderToken(context.Background(), s.wifAudience) |
Member
There was a problem hiding this comment.
I assume the intent here is to always use the AWS metadata service for generating the JWT?
Member
Author
There was a problem hiding this comment.
In our setup, yes. But more broadly this tool is OSS so any cloud provider JWT that's supported should be usable.
mpminardi
approved these changes
Feb 11, 2026
Member
mpminardi
left a comment
mpminardi
left a comment
There was a problem hiding this comment.
LGTM on the "integrating workload identity" piece but with the caveat that I don't have a ton of context on the project 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an alternative to reading a static OAuth secret from setec, allow using workload identity to authenticate to the API and set node attributes. If
--wif-client-idand--wif-audienceare set and--oauth-secretis empty, get the identity token from environment and use it for token exchange with the provided audience.Updates https://github.com/tailscale/corp/issues/36612