Conversation
ec4d431 to
7c6f61c
Compare
awly
approved these changes
Jan 16, 2026
Member
awly
left a comment
There was a problem hiding this comment.
Huh, I thought login.tailscale.com and api.tailscale.com are interchangeable!
hallpass.go
Outdated
Comment on lines
46
to
48
Member
There was a problem hiding this comment.
Suggested change
| loginServer = flag.String("login-server", "", "optional alternate URL of control server") | |
| apiServer = flag.String("api-server", "", "optional alternate URL of API server") | |
| loginServer = flag.String("login-server", "", "optional alternate URL of the control login server") | |
| apiServer = flag.String("api-server", "", "optional alternate URL of the control API server") |
The ts client itself needs the baseURL set, and a separate API URL should be used for API interactions rather than re-using the login URL. Signed-off-by: Bailey Jayes <bailey@tailscale.com>
7c6f61c to
b467d43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ts client itself needs the baseURL set, and a separate API URL should be used for API interactions rather than re-using the login URL.