patch: cmd/link: add opt-in mechanism to fail if reflect is used (was: TS_LINK_FAIL_REFLECT)

[bradfitz]

Back in our Go 1.17 toolchain, we had support (ab6e4fe) for TS_LINK_FAIL_REFLECT to make the linker explode if somebody used a IsReflectMethod value anywhere in the program. (e.g. using reflect.Value which then bloats binaries conservatively because a bunch of deadcode can't happen just in case a text/template or something looks up a method by a string)

bradfitz@bradm4-2 go % git co tailscale.go1.18
git gbranch 'tailscale.go1.18' set up to track 'origin/tailscale.go1.18'.
Switched to a new branch 'tailscale.go1.18'
bradfitz@bradm4-2 go % git grep TS_LINK_FAIL_REFLECT
bradfitz@bradm4-2 go % git co tailscale.go1.17
branch 'tailscale.go1.17' set up to track 'origin/tailscale.go1.17'.
Switched to a new branch 'tailscale.go1.17'
bradfitz@bradm4-2 go % git grep TS_LINK_FAIL_REFLECT
src/cmd/link/internal/ld/deadcode.go:           if v, _ := strconv.ParseBool(os.Getenv("TS_LINK_FAIL_REFLECT")); v {
src/cmd/link/internal/ld/deadcode.go:                   panic("unexpected reflect with TS_LINK_FAIL_REFLECT")

But we lost it in Go 1.18+

We should bring it back. We still set it in gocross.

/cc @barnstar @awly

[bradfitz]

Eh, not sure how much this matters now given that we have tests in tailscale/tailscale like:

// Test that we can build a binary without reflect.MethodByName.
// See https://github.com/tailscale/tailscale/issues/17063
func TestOmitReflectThings(t *testing.T) {
	deptest.DepChecker{
		GOOS:   "linux",
		GOARCH: "amd64",
		Tags:   "ts_include_cli,ts_omit_systray,ts_omit_debugeventbus,ts_omit_webclient",
		BadDeps: map[string]string{
			"text/template": "unexpected text/template usage",
			"html/template": "unexpected text/template usage",
		},
		OnDep: func(dep string) {
			if strings.Contains(dep, "systray") {
				t.Errorf("unexpected systray dep %q", dep)
			}
		},
	}.Check(t)
}

That's probably good enough.