Merged
Conversation
6052e1e to
f6bf0ff
Compare
f6bf0ff to
9fa40cb
Compare
9fa40cb to
04c5a82
Compare
irbekrm
approved these changes
May 9, 2024
Contributor
irbekrm
left a comment
There was a problem hiding this comment.
Nice, I tested it with a simple Caddyfile
{
tailscale {
foo {
hostname "{$FOO}"
}
bar {
hostname "{$BAR}"
}
}
}
:8081 {
bind tailscale/foo
respond "hello foo"
}
:8082 {
bind tailscale/bar
respond "hello bar"
}
and got the expected two Tailscale nodes with hostnames set to the respective env var values.
Suggestion: should we add hostname to the nested node config in the top level example Caddyfile for documentation?
Suggestion2: should we have a test case for this?
04c5a82 to
a92d1bc
Compare
e679b94 to
cff4339
Compare
Member
Author
|
added tests, as well as for the previous control_url change, which I missed. I'll document all of these new field together in an upcoming change. |
this overrides the name used to refer to the node in the caddy config, and is mostly useful because it can include environment variables. Closes #18 Co-authored-by: kdevan <kaidevan@gmail.com> Signed-off-by: Will Norris <will@tailscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this overrides the name used to refer to the node in the caddy config, and is mostly useful because it can include environment variables.
Closes #18