refactor(protocol): use immutables to avoid some address resolving #18913
+913
−874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
davidtaikocha
requested review from
YoGhurt111,
xiaodino,
cyberhorsey and
davidtaikocha
Co-authored-by: Daniel Wang <[email protected]>
dantaik
changed the title
YoGhurt111
approved these changes
Feb 13, 2025
xiaodino
approved these changes
Feb 13, 2025
This was referenced Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates several (but not all) contracts to use immutable variables, reducing resolver lookups where possible. The goal is not to eliminate IResolver entirely, as certain cases still require address resolution using (chainId, name) pairs. These specific lookups cannot be efficiently replaced with immutables.