Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taiko-client): add proof type to batch proof acceptance log messages #18885

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

StoneMac65
Copy link
Contributor

Enhances proof acceptance logs by displaying the proof type (Optimistic/SGX/ZK) in batch proof submission confirmations.

Changes:

  • Added "getProofTypeString" function to map tier IDs to human-readable names
  • Updated batch proof acceptance log to include proof type

Example output:

"🚚 Your SGX batch proofs were accepted"
"🚚 Your Optimistic batch proofs were accepted"

Tested with multiple proof types (Optimistic, SGX)
Verified log formatting and message clarity

@davidtaikocha davidtaikocha changed the title feat: Add proof type to batch proof acceptance log messages feat(taiko-client): add proof type to batch proof acceptance log messages Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 14.37%. Comparing base (d6001d3) to head (83e3a21).
Report is 782 commits behind head on main.

Files with missing lines Patch % Lines
...lient/prover/proof_submitter/transaction/sender.go 0.00% 19 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #18885       +/-   ##
===========================================
- Coverage   49.37%   14.37%   -35.01%     
===========================================
  Files          56      103       +47     
  Lines        5827    32384    +26557     
===========================================
+ Hits         2877     4654     +1777     
- Misses       2636    27213    +24577     
- Partials      314      517      +203     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidtaikocha davidtaikocha merged commit cad42a7 into taikoxyz:main Feb 7, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants