-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): use num proposals to measure forced inclusion deadline #18842
base: forced_tx_inclusion
Are you sure you want to change the base?
Conversation
feat(protocol): use num proposals to measure forced inclusion deadline
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
0a2cc23
to
ada7814
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it 🙏 Apologies for the force push, just pressed rebase button on github 🤦♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dantaik Will ForcedInclusionInbox
only be callable from the PreconfRouter
or can anyone permissionless-ly call the required function to clear the oldest forced inclusion?
Good question. I think we have at least two possible approaches:
I believe option 2 is the better approach because, with option 1, we would still need a fallback mechanism to handle cases where preconfers stop working. Option 2 directly addresses this issue by ensuring a permissionless mechanism kicks in when necessary. |
The following changes are implemented in this PR:
Replaced timestamp-based deadlines with L2 proposal count: The number of L2 proposals (batches) is now used to determine whether the oldest forced inclusion is due. This change addresses issues related to timestamp-based deadlines (see Brecht's comment).
Enabled proactive processing of inclusion requests: Proposers/preconfers are now allowed to proactively process the oldest inclusion request even before it is due.
@cyberhorsey Tests are broken and not yet fixed.