feat(protocol): allow L1 timelock to be the L2 owner #15358
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| bytes32 approvalHash = _isTransactionApproved(txdata, proof, executor); | ||
| if (approvalHash == 0) revert TX_NOT_APPROVED(); | ||
|
|
||
| (bool success,) = address(this).call(txdata); |
There was a problem hiding this comment.
If we let owner() be L1 timelock, shall we modify those onlyOwner methods in TaikoL2 (e.g. function withdraw(address token, address to) external onlyOwner), to make them only executable by the L2 executor here instead of owner()?
There was a problem hiding this comment.
Yes, but we don't override onlyOwner modifier, we overide _checkOwner. It's done in the code.
| error TX_REVERTED(); | ||
| error NOT_CALLABLE(); | ||
|
|
||
| function executeApprovedTransaction( |
There was a problem hiding this comment.
Why does this function check its own proof instead of doing things similarly to what checkProcessMessageContext where it's called directly by the bridge contract and just the original sender on the source chain needs to be checked?
There was a problem hiding this comment.
This new contract doesn't use the Bridge, instead, it interacts with the SignalService directly on the source chain directly.
There was a problem hiding this comment.
Any reason for that? Seems like this type of thing will be a common thing that people have to do for these cross layer transactions. It feels a bit strange that even we wouldn't use the standard bridge to do this.
There was a problem hiding this comment.
Using the SignalService is intuitive to me, but we can also use the Bridge. By using the bridge, maybe we can avoid the introduction of the new CrossChainOwned contract. I'll give it a try and then lets compare the two solutions.
Before this PR, the ownership of the TaikoL2 contract is really not given to the DAO as DAO lives on L1.
This PR introduces a new contract CrossChainOwned.sol that checks the owner address sent signals from L1 to L2 to authorize onlyOwner transactions.