Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce preconfirmation blocks P2P network #18

Open
wants to merge 9 commits into
base: taiko
Choose a base branch
from

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Jan 23, 2025

@davidtaikocha davidtaikocha changed the title feat: changes for taiko-geth compatibility feat: introduce preconfirmation blocks P2P network Jan 25, 2025
@davidtaikocha davidtaikocha marked this pull request as ready for review January 25, 2025 07:57
Transactions: txs,
}
block := types.NewBlock(header, &body, receipts, trie.NewStackTrie(nil), types.DefaultBlockConfig)
block := &types.Block{} // CHANGE(taiko): changes for taiko-geth compatibility.
Copy link

@mask-pp mask-pp Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change here? It's test code.

Required: required,
})
// CHANGE(taiko): changes for taiko-geth compatibility.
err := s.RPC.CallContext(ctx, &result, "engine_signalSuperchainV1", nil)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why change here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants