Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Fix build on arm64 #7978

Merged
merged 2 commits into from
May 19, 2023
Merged

Conversation

oliver-batchelor
Copy link
Contributor

Issue: #7916

Brief Summary

This was a suggested fix for building taichi on arm64 on a jetson.

@CLAassistant
Copy link

CLAassistant commented May 11, 2023

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 378ab28
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/645c8329941f3600089170d6
😎 Deploy Preview https://deploy-preview-7978--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@houkensjtu
Copy link
Contributor

Hi @oliver-batchelor ! Thank you for the PR!
Looks like this change caused several failures in the CI test. I'll try to investigate the reason for that and get back to you.

@houkensjtu houkensjtu changed the title Fix build on arm64 [build] Fix build on arm64 May 18, 2023
@houkensjtu houkensjtu requested a review from ailzhang May 18, 2023 11:51
@houkensjtu
Copy link
Contributor

Hi @oliver-batchelor ! Just some tips to share with you about the PR(pull request) process:

  1. Please include a type label in the PR title, such as the one I added for you "[build]", otherwise it will fail the "Presubmit Title Check" in our CI
  2. Sometimes CI tests might fail for random reason: it's not always your fault! If you see a failure in the CI section, try to read the error log and see if it's related to your PR. If it's not, try "rerun" the CI test ( you can find the rerun button in the "Details" page of the CI action)
  3. A PR needs at least one reviewer's approval to get merged. You can select the reviewer on the right side of the PR page.

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ailzhang ailzhang merged commit c460101 into taichi-dev:master May 19, 2023
feisuzhu added a commit to feisuzhu/taichi that referenced this pull request May 19, 2023
@feisuzhu
Copy link
Contributor

@oliver-batchelor This modification breaks some existing tests, reverting for now.

2023-05-19-143241_797x1029_scrot

feisuzhu added a commit that referenced this pull request May 19, 2023
@houkensjtu
Copy link
Contributor

Are the failed tests part of our CI procedure? I wonder why the PR passed all CI with green checks..

@feisuzhu
Copy link
Contributor

Are the failed tests part of our CI procedure? I wonder why the PR passed all CI with green checks..

Yes, and it is yet to be investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants