[DFP] Implement parsing of Decimal32 literals and printing of Decimal32 values #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change starts the base set of changes to support DFP in APFloat and allow us to parse a DFP decalration and examine the AST. Since we don't have a DFP implementation I avoided implementating much beyond the basics for APFloat.
This currently only supports Decimal32 literals.
…hafik_dfp_parse_literals
|
You may notice that I replaced |
| llvm_unreachable("Unknow DFP semantics"); | ||
| } | ||
|
|
||
| void DFPFloat::mul64By64To128(DFPFloat::Two64Wrapped &p, uint64_t cx, uint64_t cy) const { |
There was a problem hiding this comment.
A lot of this could could benefit from using utilities in MathExtras.h
…hafik_dfp_parse_literals
to support DFP have exposed bugs. The current version should now properly dispathc for DoubleAPFloat, IEEEFloat and DFPFloat.
|
Just applied a fix to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the parsing and printing of
Decimal32literals.A large part of the work was weaving through the existing
APFloatcode paths for parsing and printing of literals. The rest of the work was generalizing it so that we have paths for 32, 64 and 128.Since the delta was getting large I limited this change to only dealing with
Decimal32and will implement similar code forDecimal64andDecimal128in a follow-up PR.The parsing and printing code is port of the code from the Intel DFP library. I imported the tables as they were. I don't think there is an obvious optimization around these and it would likely be a lot of work and so I feel we should leave these as are for the first implementation and if we find issue we can revisit at that time.