Fix root_path duplication in MCP SSE messages endpoint #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… apps use root_path, the messages_path was incorrectly including the base_path, causing FastAPI to duplicate the root_path in the final URL. This fix removes the base_path from messages_path construction since FastAPI automatically prepends the root_path when serving endpoints.
|
Same issue. #163 fixed this for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes root_path duplication issue where MCP endpoints showed /api/v1/api/v1/mcp/messages/ instead of /api/v1/mcp/messages/ when FastAPI apps use root_path. The fix removes base_path from messages_path construction since FastAPI automatically prepends root_path when serving endpoints.