Python SDK Rework #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and one for the publisher
Doesn't make sense to keep it given that we only support RabbitMQ
…ct to exchanges and queues instead of creating them
Tiburso
approved these changes
Jan 29, 2025
Comment on lines
+35
to
+42
| class SerializableException(BaseModel): | ||
| """A serializable exception.""" | ||
|
|
||
| type: str | ||
| """ The type of the exception. `RuntimeError` evaluates to `"RuntimeError"`.""" | ||
|
|
||
| message: str | ||
| """ The message of the exception. """ |
There was a problem hiding this comment.
Is there a reason why the comments are below the properties here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passivemode, meaning it can't create queues and assumes they're already created. We can rework this once again in the future, perhaps using a shared Rust library so that different SDKs can share the exact same behaviour.