Skip to content

pass on proped styles to iframe if existing #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

pass on proped styles to iframe if existing #8

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
247a1f7
pass on proped styles to iframe if existing
scstan Apr 13, 2019
aebcf95
Merge branch 'master' of https://github.com/tableflip/react-responsiv…
scstan Apr 13, 2019
b6d170e
fix build
scstan Apr 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const divStyle = {
maxWidth: '100%'
}

const iframeStyle = {
let iframeStyle = {
position: 'absolute',
top: 0,
left: 0,
Expand All @@ -33,6 +33,9 @@ const ratioToPercent = (ratio) => {
const ResponsiveEmbed = (props) => {
const paddingBottom = ratioToPercent(props.ratio)
const style = Object.assign({}, divStyle, {paddingBottom})
if (props.style) {
iframeStyle = Object.assign(iframeStyle, props.style)
}
const iframeProps = Object.assign({frameBorder: 0}, props, {style: iframeStyle})
delete iframeProps.ratio
return div({style},
Expand Down