Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing PARSENAME from sys.schemas lookup in DropClass procedure #6

Closed
wants to merge 1 commit into from

Conversation

Prof-hu
Copy link

@Prof-hu Prof-hu commented Jul 15, 2016

Proposed solution to issue #5

@mbt1
Copy link
Collaborator

mbt1 commented Jul 15, 2016

Implementing this would change documented behavior and potentially break many tests for other tSQLt users.

@mbt1 mbt1 closed this Jul 15, 2016
@Prof-hu
Copy link
Author

Prof-hu commented Jul 15, 2016

@mbt1

Implementing this would change documented behavior and potentially break many tests for other tSQLt users.

What is the exact behavior that is referenced here? Can you point me to that section in the documentation?

@mbt1
Copy link
Collaborator

mbt1 commented Jul 15, 2016

The expected behavior is that you can pass in names with and without brackets. The PARSENAME function is the only reliable way to remove those brackets for further processing. Your other comment however tells me that there is a test missing. I will look into that.

@Prof-hu
Copy link
Author

Prof-hu commented Jul 15, 2016

@mbt1

The expected behavior is that you can pass in names with and without brackets. The PARSENAME function is the only reliable way to remove those brackets for further processing. Your other comment however tells me that there is a test missing. I will look into that.

I see. Then probably PARSENAME should be used at all the other WHERE clauses. It would still not work with a schema name with a dot in it supplied without brackets, but at least would work with brackets. :D

I just experimented with this a little and seem to work OK, so created another pull req with this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants