-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch config files from .js to .mjs, env.js to env.ts and next.config.js to next.config.ts #2085
Conversation
🦋 Changeset detectedLatest commit: 4850f67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.mjs
is redundant when using type: module
also I don't like advocating for ts config when you can't do ESM in them...
create-next-app is currently using both .mjs and next.config.ts (even with type module) In my opinion we should switch it as well to make it standard. |
doesn't mean it's right ;) for example you can't do ESM in ts configs: |
Alright, closing this for now. |
@juliusmarminge This works: I have also understood the downside of using .mjs directly. I'll keep this PR closed as changing these files is not at all necessary for now. Thanks for the explanation. 😉 |
Closes #2082
✅ Checklist
Changelog
The changes were made to follow the new conventions used in create-next-app.
Screenshots
Before:
After:
💯