Storage Logic with Rotate Turret Command #13
Conversation
I copy-pasted Basil's code so it should work???
| ballCount = 3; | ||
| } | ||
|
|
||
| public void spinBoth(){ |
There was a problem hiding this comment.
Probably don't need these methods, as someone else calling
spinLowerMotor() spinUpperMotor()
Isn't really burdensome, and it's just as clear.
| } | ||
|
|
||
| public void spinLowerMotor() { | ||
| lowerMotor.set(ControlMode.PercentOutput, 0.5); |
There was a problem hiding this comment.
These should be constants instead of number literals.
|
|
||
| public void stopUpperMotor() { | ||
| upperMotor.stopMotor(); | ||
| } |
There was a problem hiding this comment.
There should probably also be a way to reverse the motors, in case of the inevitable jams.
| } | ||
|
|
||
| @Override | ||
| public void execute() { |
There was a problem hiding this comment.
I think this needs more work, consider that this method will likely be called every 20ms during the match.
Since this clears all remembered state as soon as it starts, this will cause the conveyors to behave erratically, because they base their movement solely on the current value of the sensors.
Instead, you need to set "goals" for it achieve, effectively. As in, "once I see this, move till this happens," and not to forget the previous state, since that's invaluable in determining what's going on in the robot, since we don't have continuous tracking of the balls.
I have also created the Xbox controller, and I have started to try mapping ht buttons to respective commands. If you could look over that also that would be great.