-
Notifications
You must be signed in to change notification settings - Fork 0
Pull Requests
OneLemonyBoi edited this page Apr 2, 2023
·
6 revisions
Create small PRs often (Ideally separate pull requests for each new feature, or modified feature).
DO NOT CREATE MASSIVE PRs AS THEY ARE HARD TO REVIEW
Open the pull request early, even before you are done with the feature, in order to get early feedback on what you've written so far. You can indicate in the PR description that the code is not ready to be merged, and let the approver know when it is.
Before a PR can be merged into Dev, it must have the following characteristics:
- Follow the Google Java Style Guide
- Follow the team naming conventions
- COMPILE WITHOUT ERRORS
- Have no warnings for depreciated code unless previously approved by the software lead
- Contain a written description about how to verify the code in the PR works on a robot. This can be in the description of the PR, and will be used by the QA team before merging into the Main/Master branch.
NEVER PR INTO MAIN
Before approval, PRs need to be reviewed by Programming Lead as well as at least one mentor on software, unless given an exemption by a software mentor.