Reformat with Rubocop #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A consistent style helps when editing the code. Without any strong opinions I largely went for the rubocop defaults, with automatic corrections doing the bulk of the work. Some method variable names were changed to longer ones. There is a Cop that identifies methods with short names. These changes were not just to satisfy the cop, as they also make the code easier to read.
|
Thanks! I would rather not rewrite the single-line statements to |
How can we keep Ruby 3.x features from creeping in? I'm not a ruby expert so I won't know easily know if a language feature was present in 2.x. Also, are the machines on 2.x running glug? I would expect them to only need the compiled stylesheet. |
This changes to the syntax to one that is supported by Ruby 2.7 and passes Rubocop's Cops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A consistent style helps when editing the code. Without any strong opinions I largely went for the rubocop defaults, with automatic corrections doing the bulk of the work.
Some method variable names were changed to longer ones. There is a Cop that identifies methods with short names. These changes were not just to satisfy the cop, as they also make the code easier to read.
When viewing this diff it might help to turn whitespace differences off.
I tested this with Street Spirit and the output is byte for byte identical