Skip to content

Test #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Test #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fae250
chore(actions): document issues with lerna and checkout
chyzwar Sep 20, 2024
6d24073
chore(lerna): revert changelog upgrade
chyzwar Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .github/workflows/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,16 @@
name: Publish

# Inspired by:
# https://dev.to/xcanchal/automatic-versioning-in-a-lerna-monorepo-using-github-actions-4hij
# Problems:
# I tried to use github registry to publish public packages,
# but packages in github require auth to install even if package is public.
#
# Lerna use npm for publish, even if npm client is set to yarn
# Publish only use npm as client and it ignore any config in yarnrc and npmClient settings
#
# Npm token will not be configured without registry-url set in actions/setup-node
# To configure authToken for npm both registry-url and secret is needed.
#
# When publishing public package, publishConfig.access need to be configured
#
# When publishing public package, publishConfig.access need to be configured on each package
#
# Lerna need fetch-depth: 0 (full fetch) on checkout to be able generate full changelog


on:
pull_request:
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@lerna-lite/publish": "^3.9.1",
"@lerna-lite/version": "^3.9.1",
"@types/node": "^22.5.5",
"conventional-changelog-conventionalcommits": "^8.0.0",
"conventional-changelog-conventionalcommits": "^7.0.2",
"eslint": "^9.11.0",
"husky": "^9.1.6",
"lint-staged": "^15.2.10",
Expand Down
11 changes: 1 addition & 10 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1392,7 +1392,7 @@ __metadata:
"@lerna-lite/publish": "npm:^3.9.1"
"@lerna-lite/version": "npm:^3.9.1"
"@types/node": "npm:^22.5.5"
conventional-changelog-conventionalcommits: "npm:^8.0.0"
conventional-changelog-conventionalcommits: "npm:^7.0.2"
eslint: "npm:^9.11.0"
husky: "npm:^9.1.6"
lint-staged: "npm:^15.2.10"
Expand Down Expand Up @@ -2236,15 +2236,6 @@ __metadata:
languageName: node
linkType: hard

"conventional-changelog-conventionalcommits@npm:^8.0.0":
version: 8.0.0
resolution: "conventional-changelog-conventionalcommits@npm:8.0.0"
dependencies:
compare-func: "npm:^2.0.0"
checksum: 10c2/767b40c4d56d71939d9e46148c21d7bae7fb155d21effbbfa46b7ce4e21261f045175267e0626546a002eda6f6d6575524db9a3cf1288f1bdf1214ec1fbbe242
languageName: node
linkType: hard

"conventional-changelog-core@npm:^7.0.0":
version: 7.0.0
resolution: "conventional-changelog-core@npm:7.0.0"
Expand Down