Update building.md #629
Open
Update building.md #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add missing pull lfs objects to avoid broke the build git lfs fetch --all && git lfs pull && git submodule foreach --recursive 'git lfs fetch --all && git lfs pull'
|
If git-lfs is already installed then LFS objects should be pulled automatically when cloning. |
|
I update the doc to reflect this information |
|
It would be better to put the note after the block of running the deps scripts, since if it's not installed before running the clone, then that will be what installs it. The |
jacobgkau
reviewed
Jul 9, 2025
jacobgkau
previously approved these changes
Oct 14, 2025
There was a problem hiding this comment.
Based on my testing, only git lfs pull in the top directory is needed to solve the coreboot build problem (meaning manually recursing into submodules isn't needed), so I've simplified it to just that. Also adjusted the location based on @crawfxrd's feedback.
jacobgkau
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add missing pull lfs objects to avoid broke the build
git lfs fetch --all && git lfs pull && git submodule foreach --recursive 'git lfs fetch --all && git lfs pull'
sugested by crawfxrd on issue and Andrew Lane by email
it solved #617