Repository navigation
Keep avatar clear of toolbar via pure CSS layout (#131) - #245
Closed
ArthurArthurArthur0817 wants to merge 3 commits into
Closed
ArthurArthurArthur0817 wants to merge 3 commits into
ArthurArthurArthur0817 wants to merge 3 commits into
Conversation
Move #jim-stage inside .editor-stack and use relative positioning to let browser native flow push the avatar down when .editor-toolbar wraps.
Change position from fixed to absolute on .jim-stage so it anchors to .editor-stack as its containing block instead of the viewport.
jserv
requested changes
Oct 6, 2026
jserv
left a comment
Contributor
There was a problem hiding this comment.
Determine if this pull request is worth proceeding.
Align indentation of jim-stage container and its child elements to adhere to the project's gate rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Alternative proof-of-concept for #131 (and related to PR #244).
Solution
To keep the layout logic lightweight without adding a runtime listener, this approach achieves the fix using pure CSS:
<aside id="jim-stage">inside<div class="editor-stack">..editor-stack { position: relative; }..jim-stagetotop: 0.5rem;anchored to the editor stack.When
.editor-toolbarwraps into two rows, the browser's native document flow automatically pushes.editor-stackand the avatar down, keeping theRun testsbutton completely visible and clickable.Testing
.editor-toolbarwraps into two rows.Summary by cubic
Fixes the avatar overlapping the toolbar when the toolbar wraps to two rows, using pure CSS instead of a runtime listener.
#jim-stageinside.editor-stackand changes.jim-stagefromposition: fixedtoposition: absolute, so it anchors to.editor-stack(nowposition: relative) instead of the viewport.Run testsbutton visible and clickable.Written for commit c86ebb1. Summary will update on new commits.