Skip to content

Keep avatar clear of toolbar via pure CSS layout (#131) - #245

Closed
ArthurArthurArthur0817 wants to merge 3 commits into
sysprog21:mainfrom
ArthurArthurArthur0817:fix-avatar-overlap
Closed

ArthurArthurArthur0817 wants to merge 3 commits into
sysprog21:mainfrom
ArthurArthurArthur0817:fix-avatar-overlap

Conversation

@ArthurArthurArthur0817

@ArthurArthurArthur0817 ArthurArthurArthur0817 commented Oct 6, 2026 •

Copy link
Copy Markdown

Overview

Alternative proof-of-concept for #131 (and related to PR #244).

Solution

To keep the layout logic lightweight without adding a runtime listener, this approach achieves the fix using pure CSS:

  1. Move <aside id="jim-stage"> inside <div class="editor-stack">.
  2. Set .editor-stack { position: relative; }.
  3. Update .jim-stage to top: 0.5rem; anchored to the editor stack.

When .editor-toolbar wraps into two rows, the browser's native document flow automatically pushes .editor-stack and the avatar down, keeping the Run tests button completely visible and clickable.

Testing

  • Verified locally at ~1220px width where .editor-toolbar wraps into two rows.
  • Verified that no JavaScript listeners are required.

Summary by cubic

Fixes the avatar overlapping the toolbar when the toolbar wraps to two rows, using pure CSS instead of a runtime listener.

  • Moves #jim-stage inside .editor-stack and changes .jim-stage from position: fixed to position: absolute, so it anchors to .editor-stack (now position: relative) instead of the viewport.
  • The browser's native flow pushes the stage down when the toolbar wraps, keeping the Run tests button visible and clickable.
  • Aligns the stage markup's indentation with the project's gate rules.

Written for commit c86ebb1. Summary will update on new commits.

Review in cubic

Move #jim-stage inside .editor-stack and use relative
positioning to let browser native flow push the avatar down
when .editor-toolbar wraps.
cubic-dev-ai[bot]

This comment was marked as resolved.

Change position from fixed to absolute on .jim-stage so it anchors
to .editor-stack as its containing block instead of the viewport.
jserv

This comment was marked as resolved.

@jserv jserv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Determine if this pull request is worth proceeding.

Align indentation of jim-stage container and its child elements
to adhere to the project's gate rules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants