Skip to content

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Apr 4, 2024

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Cleaner but completely broken version of what GH-6 attempts.
This does not remove functionality (components).
But because TS limitations (and likely that jsx types are not very good), we can’t infer some IntrinsicElements registry from a jsx function or an Element type.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Apr 4, 2024
@wooorm wooorm changed the title Update dev-dependencies Global JSX to local JSX Apr 4, 2024
@wooorm wooorm changed the title Global JSX to local JSX Global JSX to local JSX w/ generics Apr 4, 2024
@wooorm
Copy link
Member Author

wooorm commented Oct 11, 2024

Closing this, I think it’s better for folks to define JSX: ae638ba. Similarly to how we expect a runtime to be passed in, it makes sentence that types are passed in too. And while TS doesn’t have a way to pass namespaces, a global seems good. Especially a global that is in use by millions of code examples out there.

@wooorm wooorm closed this Oct 11, 2024

This comment has been minimized.

@wooorm wooorm added the 🙅 no/wontfix This is not (enough of) an issue for this project label Oct 11, 2024
@wooorm wooorm deleted the bare-mini-jsx-namespace branch October 11, 2024 15:26
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

1 participant