Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: users cannot apply promises with invalid workflow names #421

Open
SaphMB opened this issue Mar 12, 2025 · 0 comments
Open

feat: users cannot apply promises with invalid workflow names #421

SaphMB opened this issue Mar 12, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@SaphMB
Copy link
Member

SaphMB commented Mar 12, 2025

Context
When applying a Promise with an invalid name specified for a workflow Pipeline, the feedback loop before a user knows about the issue is slow. In the case of an invalid name for a resource.configure container, the promise will reconciled successfully, advertised as available and no issues will be manifest until a resource request is made.

Acceptance
Given I have a promise.yaml that defines a resource.workflow with a container name that is not *acceptable
When I run kubectl apply -f resource.yaml
Then I am immediately informed that my promise cannot be applied due to the name being unacceptable
And there is no attempt to reconcile the promise


*Acceptable name criteria

  • contain at most 63 characters
  • contain only lowercase alphanumeric characters or '-'
  • start with an alphanumeric character
  • end with an alphanumeric character
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant